Add classic name to markdown references to gazebo#178
Open
Ryanf55 wants to merge 2 commits intoosrf:masterfrom
Open
Add classic name to markdown references to gazebo#178Ryanf55 wants to merge 2 commits intoosrf:masterfrom
Ryanf55 wants to merge 2 commits intoosrf:masterfrom
Conversation
Signed-off-by: Ryan Friedman <ryanfriedman5410+github@gmail.com>
* First did a find & replace for "Gazebo " to "Gazebo-clasic ", then filtered the diff manually * This should help make it obvious when searching online to not confuse the gazebo versions Signed-off-by: Ryan Friedman <ryanfriedman5410+github@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Make it clear that this is for the older gazebo (Gazebo Classic).
Details
I split this into two commits. The first updates the main README, while the 2nd does more of a find-replace. I only changed markdown files. I did my best to leave out any code blocks from the changes, and tried to change the name of "Gazebo Answers" to "Gazebo-classic" answers. It took about 30 minutes to go through the diff.
Perhaps the PR should be split to merge the first commit, and then discuss the 2nd in more detail on if this is a good idea?
Issue
Closes #177