Skip to content

Revert use of union types#32

Merged
osteel merged 1 commit intomainfrom
feature/revert-union-types
Jun 16, 2023
Merged

Revert use of union types#32
osteel merged 1 commit intomainfrom
feature/revert-union-types

Conversation

@osteel
Copy link
Owner

@osteel osteel commented Jun 16, 2023

Summary

This PR reverts the use of union types to narrow down the supported HTTP message types.

Explanation

We do want the interface to be as open as possible – it's the adapters' job to then narrow the types down based on what they support.

Checklist

  • I have provided a summary and an explanation
  • I have reviewed the PR myself and left comments to provide context
  • I have covered the changes with tests as appropriate
  • I have made sure static analysis and other checks are successful

@osteel osteel marked this pull request as ready for review June 16, 2023 16:22
@osteel osteel merged commit 98bbeb7 into main Jun 16, 2023
@osteel osteel deleted the feature/revert-union-types branch June 16, 2023 16:22
@osteel osteel mentioned this pull request Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments