Skip to content

PHPStan#34

Merged
osteel merged 1 commit intomainfrom
feature/phpstan
Jun 19, 2023
Merged

PHPStan#34
osteel merged 1 commit intomainfrom
feature/phpstan

Conversation

@osteel
Copy link
Owner

@osteel osteel commented Jun 19, 2023

Summary

This PR adds PHPStan to analyse the codebase's typing (level 9).

Explanation

Potential breaking change – MessageAdapterInterface@convert now returns ResponseInterface|ServerRequestInterface instead of MessageInterface.

Checklist

  • I have provided a summary and an explanation
  • I have reviewed the PR myself and left comments to provide context
  • I have covered the changes with tests as appropriate
  • I have made sure static analysis and other checks are successful

@osteel osteel force-pushed the feature/phpstan branch from f116216 to 9a73b9e Compare June 19, 2023 15:14
@osteel osteel marked this pull request as ready for review June 19, 2023 15:15
@osteel osteel merged commit 7716190 into main Jun 19, 2023
@osteel osteel deleted the feature/phpstan branch June 19, 2023 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments