Conversation
Contributor
Author
|
As far as I can tell from Github Actions YAML definition I do not need to touch it to address the |
Add ^7.0 version constraint to Symfony Cache and Symfony HTTP foundation packages, plus the PSR HTTP message bridge.
Contributor
Author
|
I ran all composer scripts as per CONTRIBUTING:
During the Detected deprecations in use:
- Rule "function_typehint_space" is deprecated. Use "type_declaration_spaces" instead.
- Rule "native_function_type_declaration_casing" is deprecated. Use "native_type_declaration_casing" instead.
- Rule "no_unneeded_curly_braces" is deprecated. Use "no_unneeded_braces" instead. |
Owner
|
Thanks for your contribution @ttomdewit! I need to check why Thanks for pointing out the deprecations as well, will have a look |
osteel
approved these changes
Nov 29, 2023
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add ^7.0 version constraint to Symfony Cache and Symfony HTTP foundation packages.
Summary
Simply extending the version constraint in
composer.json.Explanation
I need to see if I can extend the Github Actions if required.
Checklist
and an explanationI have covered the changes with tests as appropriate- N/A