🐛 Fix MaxUint32 assignment to platform int#47
Merged
osteele merged 1 commit intoosteele:masterfrom Jul 5, 2021
luminsmart-archive:master
Merged
🐛 Fix MaxUint32 assignment to platform int#47osteele merged 1 commit intoosteele:masterfrom luminsmart-archive:master
osteele merged 1 commit intoosteele:masterfrom
luminsmart-archive:master
Conversation
This fixes an issue where math.MaxUint32 is assigned to a platform dependent int type. This works on 64-bit platforms without issue due to there being plenty of space. On 32-bit platforms this is wrong and will not compile as math.MaxUint32 > math.MaxInt32.
Contributor
Author
|
Would you like me to also open an associated issue? |
Contributor
Author
|
Looks like the build failed due to a missing golangci-lint. |
Owner
|
Thanks. No need for a separate issue. I have ported the CI from Travis to GitHub Actions; if you rebase your work on master then the CI should pass. Please also make the same change to |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an issue where math.MaxUint32 is assigned to a platform
dependent int type. This works on 64-bit platforms without issue due to
there being plenty of space. On 32-bit platforms this is wrong and will
not compile as math.MaxUint32 > math.MaxInt32.
Checklist
make testpasses.make lintpasses.