-
Notifications
You must be signed in to change notification settings - Fork 339
aboot: Add missing stdint.h include #3541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Without this include, builds on musl systems end up with the following
error:
```
src/libostree/ostree-bootloader-aboot.c:136:18: error: 'uintptr_t'
undeclared (first use in this function)
136 | int fd = (int)(uintptr_t)data;
| ~~~~~~~~
```
To ensure no regressions for musl, add a job that builds ostree in Alpine container.
|
Hi @vadorovsky. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly adds the missing <stdint.h> include to src/libostree/ostree-bootloader-aboot.c. This resolves a build failure on musl-based systems where uintptr_t is not implicitly available. The change is correct and necessary. I have one minor suggestion to improve the organization of header includes for better code consistency.
| #include "otutil.h" | ||
| #include <sys/mount.h> | ||
|
|
||
| #include <stdint.h> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Disagree, I think that would add noise to the diff.
Without this include, builds on musl systems end up with the following
error: