Skip to content

Conversation

@vadorovsky
Copy link

Without this include, builds on musl systems end up with the following
error:

src/libostree/ostree-bootloader-aboot.c:136:18: error: 'uintptr_t'
    undeclared (first use in this function)
  136 |   int fd = (int)(uintptr_t)data;
      |                  ~~~~~~~~

Without this include, builds on musl systems end up with the following
error:

```
src/libostree/ostree-bootloader-aboot.c:136:18: error: 'uintptr_t'
    undeclared (first use in this function)
  136 |   int fd = (int)(uintptr_t)data;
      |                  ~~~~~~~~
```
To ensure no regressions for musl, add a job that builds ostree in
Alpine container.
@openshift-ci
Copy link

openshift-ci bot commented Oct 23, 2025

Hi @vadorovsky. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly adds the missing <stdint.h> include to src/libostree/ostree-bootloader-aboot.c. This resolves a build failure on musl-based systems where uintptr_t is not implicitly available. The change is correct and necessary. I have one minor suggestion to improve the organization of header includes for better code consistency.

#include "otutil.h"
#include <sys/mount.h>

#include <stdint.h>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This include is correct. For better code consistency, consider grouping all system headers and sorting them alphabetically. This would also remove the blank line that separates system includes. For example:

#include <stdint.h>
#include <string.h>
#include <sys/mount.h>

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disagree, I think that would add noise to the diff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants