Ignore typedef-redefinition warnings with Clang and Fix enum type mismatch in copy flags #3592
Ignore typedef-redefinition warnings with Clang and Fix enum type mismatch in copy flags #3592bbhtt wants to merge 2 commits into
Conversation
redefinition is legal in C11 and before that via gcc extension Fixes: ostreedev#3590
|
Hi @bbhtt. Thanks for your PR. I'm waiting for a ostreedev member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Code Review
This pull request updates the build configuration to suppress typedef redefinition warnings when using Clang and modifies the directory attribute copying logic in the sysroot deployment process to use converted flags via sysroot_flags_to_copy_flags. I have no feedback to provide as there are no review comments.
|
Failures seem to be unrelated, GCC 16 issues. |
Fixes: #3590
Fixes: #3591