Skip to content

Ignore typedef-redefinition warnings with Clang and Fix enum type mismatch in copy flags #3592

Open
bbhtt wants to merge 2 commits into
ostreedev:mainfrom
bbhtt:bbhtt/fix-werrors
Open

Ignore typedef-redefinition warnings with Clang and Fix enum type mismatch in copy flags #3592
bbhtt wants to merge 2 commits into
ostreedev:mainfrom
bbhtt:bbhtt/fix-werrors

Conversation

@bbhtt
Copy link
Copy Markdown

@bbhtt bbhtt commented May 16, 2026

Fixes: #3590
Fixes: #3591

redefinition is legal in C11 and before that via gcc extension

Fixes: ostreedev#3590
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 16, 2026

Hi @bbhtt. Thanks for your PR.

I'm waiting for a ostreedev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@bbhtt bbhtt force-pushed the bbhtt/fix-werrors branch from 3940acb to 8171cf7 Compare May 16, 2026 07:01
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the build configuration to suppress typedef redefinition warnings when using Clang and modifies the directory attribute copying logic in the sysroot deployment process to use converted flags via sysroot_flags_to_copy_flags. I have no feedback to provide as there are no review comments.

@bbhtt
Copy link
Copy Markdown
Author

bbhtt commented May 16, 2026

Failures seem to be unrelated, GCC 16 issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enum type mismatch in ostree-sysroot-deploy Redefinition of typedef 'OstreeContentWriter'

1 participant