-
-
Notifications
You must be signed in to change notification settings - Fork 1k
Support for AMD ROCm compatible GPUs. #559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
No plan at windows radeon support? |
4ee414d to
6a52af4
Compare
If by Radeon support you mean any card that has ROCm support, then the answer is yes. However, I will need some time to setup a windows environment to try it. It would be nice if someone with a Windows setup could contribute it, considering that it could be a very easy patch. It works with other low end cards as well. It is in no way limited to the AI PRO R9700. |
|
|
||
| async function getAMDGpuStats(isWindows: boolean) { | ||
| // Execute command | ||
| const command = 'amd-smi static --json && echo ";" && amd-smi metric --json'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This command will fail on systems with an inactive AMD iGPU in addition to an AMD discrete GPU.
The amd-smi metric JSON returns an empty usage attribute in gpu_data for an inactive iGPU looking like:
"usage": "N/A",
|
There's an issue for systems with an inactive iGPU on line 147 of ui/src/app/api/gpu/route.ts. The JSON returned for an inactive iGPU has an empty usage attribute. Here's what the first chunk of an iGPU looks like: The missing data kills the parsing and prevents other GPUs from being detected. |
|
Thanks for the comment. Will change the patch with a renewed improved version. |
6a52af4 to
3c65577
Compare
3c65577 to
b75d940
Compare
|
Update, latest bitsandbytes packages now include rocm support. I was able to run with it and your changes. |
This patch adds support for AMD ROCm capable GPUs to the project, for Linux at the moment.
Hope you find the implementation sane and complete.
I have been using it for the last couple of days with great success.