Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! First of all - thank you for this library; it’s really one of the most capable and pleasant to use: rich feature set and a clean API.
This PR fixes a bug when markWord is used multiple times (e.g. several enhancers in a row). In your tokenization example it was failing because after the first markWord run, the leaf node in some paths became a node of type mark instead of text. On the next markWord run, leafOf(path) was called for those paths; leafOf expects a text node and throws otherwise (Invalid token path with leaf of type mark). That’s why tokenization didn’t complete in your own example. The fix: if the path’s leaf node is already non-text (e.g. a mark), we return the path unchanged and don’t call leafOf, so multiple markWord enhancers can be chained without errors
P.S: maybe it can fix #234 issue
UPD: add logs

