This repository was archived by the owner on Oct 3, 2025. It is now read-only.
[FIX][DM-562] Allow JSON GET request to not specify body #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EslamTharwatotrium
approved these changes
Apr 17, 2024
* Odoo assumes JSON body is set for any JSON requests, including GET requests where this is not needed. By setting the body to an empty dictionary if not set we avoid the need for external systems to do this.
PeterC10
force-pushed
the
11.0_DM-562_json_get_fix
branch
from
4d2e90f to
b9c7027
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently Odoo assumes that a request body is set for any JSON API requests, even though this is not required. See "params" here: https://www.jsonrpc.org/specification#request_object
This change will set the request body to be empty if not set, as Odoo did allow for JSON API GET requests to be sent with an empty body set. This allows external services to make JSON API GET requests without needing to specify a body, something which some applications do not allow.