Closed
Conversation
Prior to this commit the `runners/trytls/utils.py` script would fail to execute on Python 3.8+ systems. This is because the deprecated `platform.linux_distribution` func used by this script was removed in Python 3.8. This commit updates the script to try to conditionally use the `distro` module[1] as a replacement. The `setup.py` script is updated to conditionally require this dependency on systems using Python 3.8+. This change is sufficient to get trytls working on my Python 3.10 system. [0]: https://docs.python.org/3.7/library/platform.html#platform.linux_distribution [1]: https://pypi.org/project/distro/
This was referenced Mar 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this commit the
runners/trytls/utils.pyscript would fail to execute on Python 3.8+ systems. This is because the deprecatedplatform.linux_distributionfunc used by this script was removed in Python 3.8.This commit updates the script to try to conditionally use the
distromodule as a replacement. Thesetup.pyscript is updated to conditionally require this dependency on systems using Python 3.8+.This change is sufficient to get trytls working on my Python 3.10 system.