-
Notifications
You must be signed in to change notification settings - Fork 3.7k
update flake to new apple sdk #25359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
WalkthroughThe Changes
Possibly related PRs
Pre-merge checks✅ Passed checks (2 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (1)
flake.lockis excluded by!**/*.lock
📒 Files selected for processing (1)
flake.nix(1 hunks)
| ] ++ pkgs.lib.optionals pkgs.stdenv.isDarwin [ | ||
| # macOS specific dependencies | ||
| pkgs.darwin.apple_sdk.frameworks.CoreFoundation | ||
| pkgs.darwin.apple_sdk.frameworks.CoreServices | ||
| pkgs.darwin.apple_sdk.frameworks.Security | ||
| # macOS specific dependencies - use latest supported Apple SDK | ||
| pkgs.apple-sdk | ||
| ]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧹 Nitpick | 🔵 Trivial
Darwin SDK migration looks correct; consider SDK version pinning / redundancy.
Switching to pkgs.apple-sdk under the Darwin-only block matches the new nixpkgs Darwin SDK pattern and replaces the deprecated darwin.apple_sdk.frameworks.* approach. (nixos.org) Note that clangStdenv already wires in the default unversioned apple-sdk, so explicitly listing pkgs.apple-sdk here is a bit redundant unless you later choose a specific version like pkgs.apple-sdk_14/_15 to stabilize Darwin builds across future nixos-unstable updates. (nixos.org) I’d keep this change (it clearly documents the SDK dependency) but consider pinning a version if you hit regressions when the default SDK moves.
Please re-check nix develop on both x86_64-darwin and aarch64-darwin once the upstream nixpkgs SDK changes you’re depending on are available, to confirm there are no remaining SDK resolution/linking issues.
🤖 Prompt for AI Agents
In flake.nix around lines 121 to 124, the Darwin block currently adds the
unversioned pkgs.apple-sdk which is redundant with clangStdenv and may cause
future regressions; either pin to a concrete SDK (e.g., replace pkgs.apple-sdk
with pkgs.apple-sdk_14 or pkgs.apple-sdk_15 to stabilize builds) or keep the
unversioned entry but add a comment explaining the intentional redundancy; after
changing, run nix develop on x86_64-darwin and aarch64-darwin to verify SDK
resolution and linking succeed.
What does this PR do?
nix developwas failing with errors mentioning that the apple sdk was outdated. This PR updates the referenced version of the apple SDK, along with the flake more generally.How did you verify your code works?
ran
nix developand confirmed that the error no longer occurs. However, in the nix shellbun bdstill fails; I think we are waiting on this PR and another flake update to resolve that.