Skip to content

Song 499 improve docker infra #510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rtisma merged 10 commits into from
Nov 18, 2019
Merged

Song 499 improve docker infra #510

rtisma merged 10 commits into from
Nov 18, 2019

Conversation

@rtisma
Copy link
Contributor

@rtisma rtisma commented Nov 18, 2019

  • added dcc-id server
  • re-did docker-compose, similar to what was done for score. No more network_mode: host. Everything is contained within a docker network.
  • improved make file for testing

Related to #499

@rtisma rtisma added this to the Code Monkeys - Sprint 18 milestone Nov 18, 2019
@rtisma rtisma requested a review from andricDu November 18, 2019 18:46
@rtisma rtisma self-assigned this Nov 18, 2019
andricDu
andricDu approved these changes Nov 18, 2019
View reviewed changes
Copy link
Contributor

@andricDu andricDu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rtisma rtisma merged commit dc6c97f into develop Nov 18, 2019
@rtisma rtisma deleted the song-499-improve-docker-infra branch November 18, 2019 19:54
@rtisma rtisma mentioned this pull request Nov 18, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@andricDu andricDu andricDu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@rtisma rtisma

Labels

None yet

Projects

None yet

Milestone

Code Monkeys - Sprint 18

Development

Successfully merging this pull request may close these issues.

3 participants

@rtisma @andricDu