Enhancement: Remove auto unpublish #554
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtisma
suggested changes
Dec 5, 2019
song-server/src/main/java/bio/overture/song/server/service/FileModificationService.java
Outdated
Show resolved
Hide resolved
song-server/src/test/java/bio/overture/song/server/service/FileModificationServiceTest.java
Outdated
Show resolved
Hide resolved
song-server/src/test/java/bio/overture/song/server/service/FileModificationServiceTest.java
Outdated
Show resolved
Hide resolved
song-server/src/test/java/bio/overture/song/server/service/FileModificationServiceTest.java
Outdated
Show resolved
Hide resolved
song-server/src/main/java/bio/overture/song/server/service/FileModificationService.java
Outdated
Show resolved
Hide resolved
song-server/src/test/java/bio/overture/song/server/service/FileModificationServiceTest.java
Outdated
Show resolved
Hide resolved
Bugfix: Now checks the content type of the request rather than just UNPUBLISHED status. Code Cleanup: Fixed order of expected vs actual parameters to assertEquals() tests in FileModificationServiceTest.
rtisma
suggested changes
Dec 6, 2019
song-server/src/main/java/bio/overture/song/server/service/FileModificationService.java
Outdated
Show resolved
Hide resolved
| assertEquals(UNPUBLISHED, noChangeResponse.getOriginalAnalysisState()); | ||
| assertEquals(originalFile, noChangeResponse.getOriginalFile()); | ||
| assertEquals( | ||
| "Updated file with objectId 'FI1' and analysisId 'AN1'", noChangeResponse.getMessage()); |
Contributor
There was a problem hiding this comment.
shouldnt this be "No Update for file..."
| assertEquals( | ||
| noChangeResponse.getMessage(), | ||
| "Original analysisState 'PUBLISHED' was not changed since the fileUpdateType was 'NO_UPDATE'"); | ||
| "Updated file with objectId 'FI1' and analysisId 'AN1'", noChangeResponse.getMessage()); |
Contributor
There was a problem hiding this comment.
shouldnt this be "No update for file...."
rtisma
approved these changes
Dec 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.