Bugfix: sing now computes it's parent directory correctly

[KevinFHartmann]

Enhancement: docker client now runs as a song user that has the sing binary in the PATH environment variable

[rtisma]

Please also update the Dockerfile.dev file, and the ./docker/tools/song-client-dev to work. in addition, add this line to the song-client and score-client service definition:
user: "$MY_UID:$MY_GID"

All the scripts in ./docker/tools need to work. For example, in song-client-dev, i had to change the last line from:
run --rm song-client bin/sing $@
to
run --rm song-client ./bin/sing $@

[rtisma]

although i appreciate restricting usage to a user called song, it makes usage of this container a little more difficult. If a directory is mounted, by default its mounted as root and so the user song wont be able to write to it. there are 2 fixes:

1. run the container with --user "$(id -u):$(id -g)"which overwrites the USER song line you have. this means all files/directories created in the mount path will have the permissions supplied from --user. This basically overrides USER song line

2. remove the USER song line, so that if a directory/file is created on the mount path by the container, those files/directories will be owned by root, and since the owner of the mounted directory is root, the whole "permission denied" issue is overcome.

Looking at 1 and 2, the best solution i can see is to remove the USER song line (and therefore the groupadd line as well).

[rtisma]

bit of a chicken-and-egg problem here, which is why this command does not work. The docker container for score-client doesnt have the executable on the class path yet. that fix is in this pr: overture-stack/score#215

for consistency sake, change this line back to

run --rm score-client bin/score-client $@

and in a new PR, we can update the version of the score-client/score-server docker images and then use the executable name only

[rtisma]

refer to above comment

[rtisma]

in addition, the line

SONG_CLIENT_CMD := $(DOCKER_COMPOSE_CMD) run --rm -u $(THIS_USER) song-client bin/sing

In the Makefile no longer works. This can be tested with make clean test-manifest

The fix is to drop the bin/, so it would instead be

SONG_CLIENT_CMD := $(DOCKER_COMPOSE_CMD) run --rm -u $(THIS_USER) song-client sing