Skip to content

Fix matched normal #577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rtisma merged 2 commits into from
Jan 13, 2020
Merged

Fix matched normal #577

rtisma merged 2 commits into from
Jan 13, 2020

Conversation

@rtisma
Copy link
Contributor

@rtisma rtisma commented Jan 13, 2020 •
edited
Loading

  • added analysisTypeId validation via jsonSchema instead of in java code
  • renamed /schemas/meta endpoint to /schemas/registration and associated method calls and variables
  • made registration a prohibited analysisType name and added test
  • added json schema constraint that matchedNormalSubmitterSampleId must be null when tumourNormalDesignation != 'Tumour'
  • adjusted all fixtures for new base schema constraint

@rtisma rtisma requested a review from andricDu January 13, 2020 13:56
@rtisma rtisma self-assigned this Jan 13, 2020
@rtisma rtisma added this to the Code Monkeys - Sprint 21 milestone Jan 13, 2020
andricDu
andricDu approved these changes Jan 13, 2020
View reviewed changes
song-server/src/test/java/bio/overture/song/server/utils/EndpointTester.java
// GET /schemas/meta
public ResponseOption getMetaSchemaGetRequestAnd() {
return initWebRequest().endpoint(SLASH.join(SCHEMAS, META)).getAnd();
// GET /schemas/registration
Copy link
Contributor

@andricDu andricDu Jan 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't need to change now, but proper java doc on public methods if you are going to comment

@rtisma rtisma merged commit 232b8c6 into develop Jan 13, 2020
@rtisma rtisma deleted the fix-matched-normal branch January 13, 2020 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@andricDu andricDu andricDu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@rtisma rtisma

Labels

None yet

Projects

None yet

Milestone

Code Monkeys - Sprint 21

Development

Successfully merging this pull request may close these issues.

3 participants

@rtisma @andricDu