Remove ICGC References - Provide only a single Manifest Service

[joneubank]

Summary of request

SCORe currently provides two implementations for handling a file download manifest, one labelled icgc and another labelled kf. The default implementation used is icgc, kf is only used when the profile kf is provided to the client. There is little documentation in the current repo on the structure of Manifests, but all Overture DMS documentation and guides have assumed the use of the icgc model. It is unclear if the kf model is still in use, and there is no intention to continue to support multiple manifest formats.

We want to refactor the manifest package to only include a single manifest implementation. We will remove the kf implementation entirely. The icgc implementation can be renamed and the implementation code moved into the manifest package (no more /icgc package).

Details

• Remove package and files: java/bio/overture/score/client/manifest/kf
• Move files from java/bio/overture/score/client/manifest/kf into java/bio/overture/score/client/manifest
• Rename IcgcManifestService to ManifestServiceImpl
• Remove all references of @Profile("!kf") form classes in java/bio/overture/score/client/manifest

Additional context

Include any relevant context or screenshots regarding your request here.

Future Work

SCORe should clearly document the file properties required in a manifest and state what format the manifest file should be. This will allow projects to export SCORe compatible manifests.