Skip to content

Auth to metadata #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jaserud merged 4 commits into from
Aug 4, 2021
Merged

Auth to metadata #314

jaserud merged 4 commits into from
Aug 4, 2021

Conversation

@jaserud
Copy link
Contributor

@jaserud jaserud commented Jul 29, 2021 •
edited
Loading

changes:

  • use serviceTemplate (which is the restTemplate being used to talk to score with oauth configs) to make request to /entities endpoints instead of directly using objectMapper

this change doesn't affect current song-score client operations, and is being made to support: #279

@jaserud jaserud requested review from andricDu and lepsalex July 29, 2021 18:13
lepsalex
lepsalex approved these changes Aug 4, 2021
View reviewed changes
Copy link

@lepsalex lepsalex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jaserud jaserud merged commit 62e03ff into develop Aug 4, 2021
@jaserud jaserud deleted the auth-to-metadata branch August 4, 2021 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andricDu andricDu Awaiting requested review from andricDu

1 more reviewer

@lepsalex lepsalex lepsalex approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jaserud @lepsalex