Search feature for the Android App

[supportreq]

Adding a search above the file listing

---

Edited by @davigonz from here on

---

We are going to face this in different stages:

1. Local search [DONE]

Here you have a gif showing how the local search looks like

2. Search using API: owncloud/core#25373 (comment)

owncloud/core#31873

CC @michaelstingl @jesmrec

[tobiasKaminsky]

Do you mean a filter function for one folder:
Current folder contains 500 files, you type "abc" in filter and it shows only 2 files?
(this should be easy, though the right UX should be discussed a bit more).

Or do you want a real search:
Searching for "abc" on the server across all folders? Then the results have to be shown with the folder where the file lies...
(much more complex)

[supportreq]

we can start with the first filter.. something which apps like dropbox offers

[tobiasKaminsky]

I have splitted "filter function" to #696, so this issue is all about real search.

[tobiasKaminsky]

@davivel @jancborchardt

Searching is usually done from a "magnifying glass" button in the action bar; the input field is then put in the action bar, replacing the title.

Your proposal is the same like dropbox does it?
But I think it would be good to have the folder structure shown. For example on the screenshot no one can distinguish the "test" folder or say where they are located.

[jancborchardt]

@tobiasKaminsky then in case of two exactly same folder names in the results we can show the path in parentheses behind it. If the names are all unique, no need to show the path. (This is similar how Sublime Text does it for open files.)

[tobiasKaminsky]

@jancborchardt Hmm. My intension to display the path is that the user can navigate next time to the desired file without searching again. Or how would he know, that file "test.jpg" is in /images/wedding/ ?
The navigation bar on the top of the display is only displayed when you browse in a folder.
But if you would open an image directly you will never know where this file is located in owncloud.

[davivel]

@jancborchardt Parentheses? May be "heavy". What about path in smaller text under the name?

@tobiasKaminsky , we can reconsider the preview layout to show the current path in some place.

[jancborchardt]

@davivel good call, path in smaller text under the name. Then we can also show it always @tobiasKaminsky

[supportreq]

Hey guys, any update for this?

[mahermeg17]

hi, any update for local or remote search feature ?

[mahermeg17]

Hi,
Following the sort feature, I added a filter to the FileListListAdapter.java like this :

public void filterByName(String keyName) {
mFilteredFiles=new Vector<OCFile>();
for(OCFile f :mFiles){
if(f.getFileName().contains(keyName)){
mFilteredFiles.add(f);
}
}
mFiles=mFilteredFiles;
Log.d("FileListListAdapter", ">>>notifyDataSetChanged");
notifyDataSetChanged();
Log.d("FileListListAdapter", ">>>notifyDataSetChanged.. OK");
}

and into the FileDisplayActivity.java :

@Override
public boolean onOptionsItemSelected(MenuItem item) {
.....
case R.id.action_search: {
SharedPreferences appPreferences = PreferenceManager.getDefaultSharedPreferences(this);
// Read sorting order, default to sort by name ascending
Integer sortOrder = appPreferences.getInt("sortOrder", FileListListAdapter.SORT_NAME);
AlertDialog.Builder builder = new AlertDialog.Builder(this);
builder.setTitle("Title");
builder.setMessage("Message");
// Set an EditText view to get user input 
final EditText input = new EditText(this);
builder.setView(input);
builder.setPositiveButton("Ok", new DialogInterface.OnClickListener() {
public void onClick(DialogInterface dialog, int whichButton) {
String value = input.getText().toString().trim();
filterByName(value);
}
});
builder.setNegativeButton("Cancel", new DialogInterface.OnClickListener() {
public void onClick(DialogInterface dialog, int whichButton) {
// Canceled.
}
});
builder.show();
break;
}
....
}   

this works and return the filtred list. But at the first sync thread launched after the search, the listview is refreched as it is in the server (not filtred).
Shoud I use a new listview result and show in the AlertDialog ? or are there an other easier way ?