Updated some css and translations #922
Conversation
DeepDiver1975
left a comment
DeepDiver1975
left a comment
There was a problem hiding this comment.
- see comment
- you wanted to remove the weekday picker in some cases - different PR?
templates/part.eventsrepeat.php
Outdated
| <label class="pull-left inline"> | ||
| <?php p($l->t('Repeat on every ...')); ?> | ||
| </label> | ||
| <div class="pull-right pull-half"> |
There was a problem hiding this comment.
if I remove .pull-half it looks like this .... a bit better from my pov and consumes less or equal space
@Julian1998 what do you think?
There was a problem hiding this comment.
I will update this PR in some days... ;)
templates/editor.sidebar.php
Outdated
| <ul class="dropdown-menu" uib-dropdown-menu role="menu" aria-labelledby="single-button"> | ||
| <li role="menuitem"><a ng-click="delete()" href="#"><?php p($l->t('Delete all')); ?></a></li> | ||
| <li role="menuitem"><a ng-click="deleteOccurrence()" href="#"><?php p($l->t('Delete just occurrence')); ?></a></li> | ||
| <li role="menuitem"><a ng-click="deleteOccurrence()" href="#"><?php p($l->t('Delete this event')); ?></a></li> |
There was a problem hiding this comment.
Maybe we need to add the date and time of the explicit event.
After opening one event you basically get the series editor - the relation to 'this event' is missing
There was a problem hiding this comment.
You are right! I would suggest that we "fix" the series editor. If you click on any repeating event you will just see the start and end time of the first event... So every occurrence should have it's own start and end time... But I think that's a way bigger problem because datetimepicker initialization and fullcalendar have no possibility to work together right now
-> new PR
|
We have to limit recurrence rule combinations:
|
Codecov Report
@@ Coverage Diff @@
## master #922 +/- ##
==========================================
- Coverage 57.54% 56.95% -0.59%
==========================================
Files 66 66
Lines 3295 3371 +76
==========================================
+ Hits 1896 1920 +24
- Misses 1399 1451 +52
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
- more descriptive text in option dropdown
- text alignment on repeat tab
- custom tab: one line "Repeat every [int] [days|...]"
- alignment of end
- disable not selected end options
- no weekdays on months
- end options: never, after [int] events, at [datepicker]
- no time on end date picker
- on monthly: every [1|2|3|4|last] [monday|...]
- delete button: "Delete this event (date)"
|
|
see https://momentjs.com/docs/#/displaying/format/ - use format string Do |
|
DeepDiver1975
force-pushed
the
cssAndTranslationUpdate
branch
from
be2e543 to
056c4ba
Compare
DeepDiver1975
force-pushed
the
cssAndTranslationUpdate
branch
from
056c4ba to
706f98f
Compare
No description provided.