migration from stable8.2 to stable9 #28256

phisch · 2017-06-29T06:30:18Z

Description

This PR adds a migration from stable8.2 to stable9. The migration runs before the stable9 to stable10 migration, therefore it is possible to upgrade from stable8.2 to stable10 directly.

Related Issue

https://github.com/owncloud/enterprise/issues/2010

Motivation and Context

So people can update more easily.

How Has This Been Tested?

Currently only by hand, by me. Will be tested automatically. Need help from qa though!

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

My code follows the code style of this project.
My change requires a change to the documentation. <- maybe, to get awareness
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes.
All new and existing tests passed.

phisch · 2017-06-29T06:35:01Z

core/Migrations/Version20170101010100.php

+		}
+
+		if ($schema->hasTable("${prefix}file_map")) {
+			$schema->dropTable("${prefix}file_map");


@DeepDiver1975 @PVince81 i don't know what data is in this table. Is it important, do i have to transform and put it into another table?

no - this data is not needed

PVince81 · 2017-06-29T08:28:21Z

PVince81 · 2017-06-29T08:34:50Z

One worry is that some "update.php" code relies on other stuff being migrated first through other means.

So if we put these update.php routines into migrations, I suggest to order them exactly by order of major versions. So run the update.php codes from stable9 before running the stable9.1 migrations, etc. Just to be sure.

Ideal would be to also have test cases that cover whatever these update.php routines were fixing.

phisch · 2017-07-12T12:32:21Z

files_trashbin: file exists but some pieces were deleted in stable10

The expire trash background task has been moved into the appinfo.xml: https://github.com/owncloud/core/blob/master/apps/files_trashbin/appinfo/info.xml

Might need to execute automatically on update?

files_external update routine is gone: it converts an older storage config format to "oc_mounts" etc tables

This is a real concern. We need to add the migration steps that are here:
https://github.com/owncloud/core/blob/stable9/apps/files_external/migration/storagemigrator.php

@PVince81 should i add it to the app again? Or should we include it in the core migrations?

files_versions: file deleted in stable10

Background job available as Command in https://github.com/owncloud/core/blob/master/apps/files_versions/appinfo/info.xml
No work required here!

user_ldap: update.php was removed in the marketplace version
The update groups logic has been moved to https://github.com/owncloud/user_ldap/blob/master/lib/Jobs/UpdateGroups.php and enabled in info.xml

The CleanUp job has been removed since the tables it was cleaning do not exist anymore.
This looks fine for me. No work required!

TODO:

check if files_trashbin OCA\Files_Trashbin\Command\ExpireTrash need to be executed on update

Trashbin expire during update was extracted into a command, because it can cause the update to take extremely long for large instances. This means we don't need to do this for this update.

add migrations for https://github.com/owncloud/core/blob/stable9/apps/files_external/migration/storagemigrator.php

PVince81 · 2017-07-12T13:48:57Z

if adding stuff back to update.php is quicker then I suggest we go that route. I expect that after the OC to 10.0 migration we might remove these again at some point...

CLAassistant · 2017-07-13T11:30:18Z

All committers have signed the CLA.

PVince81 · 2017-07-18T12:02:05Z

I'd like to see the checkboxes here updated before merging: #28256 (comment)

phisch · 2017-07-28T07:37:36Z

The storagemigration (https://github.com/owncloud/core/blob/stable9/apps/files_external/migration/storagemigrator.php) can't be added here because of missing services in the files_external app.

If we want to support migrating global and user mounts, we should add those legacy services again to files_external and add it as migration there.

PVince81 · 2017-08-03T13:35:57Z

If we want to support migrating global and user mounts, we should add those legacy services again to files_external and add it as migration there.

that would be fine

…ve mysql table

…finition

…der they where added which fails some expectations in tests

PVince81 · 2017-08-07T14:21:39Z

@phisch can you post a list of items/checkbox of the ton of testing you have done lately?

PVince81 · 2017-08-07T14:22:03Z

and also please update the checkboxes above with the bits you have already fixed. Thanks

phisch · 2017-08-11T10:53:29Z

Tested the migration for all major databases:

sqlite
mysql
pgsql
oracle

Looked for missing actions/migrations from update.php files in apps. There are no missing actions except for the mounts that will be added in the files_external app.

Merging this PR.

PVince81 · 2017-08-11T11:00:50Z

@phisch thanks. Will you add this separately ?

add migrations for https://github.com/owncloud/core/blob/stable9/apps/files_external/migration/storagemigrator.php

PVince81 · 2017-08-11T11:01:00Z

please backport this PR to stable10

phisch · 2017-08-11T11:08:12Z

Will you add this separately ?

@PVince81 yes

Backport incomming.

* added migration from stable8.2 to stable9 * addressbooks.description can be null * added missing changes from diff between migrated mysql table and native mysql table * added autoincrement, unsigned, notnull and collation explicitly * needed to set notnull to false explicitly and remove the collation definition * order mounts by storage_id, because postgres returns it not in the order they where added which fails some expectations in tests

[stable10] migration from stable8.2 to stable9 (#28256)

lock · 2019-08-02T21:02:27Z

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

phisch added the 3 - To Review label Jun 29, 2017

phisch added this to the 10.0.3 milestone Jun 29, 2017

phisch self-assigned this Jun 29, 2017

phisch requested review from DeepDiver1975, IljaN and PVince81 June 29, 2017 06:30

phisch commented Jun 29, 2017

View reviewed changes

PVince81 mentioned this pull request Jul 10, 2017

fileid of oc_filecache in danger of hitting max value #26901

Closed

DeepDiver1975 added 2 - Developing and removed 3 - To Review labels Jul 11, 2017

PVince81 added the p1-urgent Critical issue, need to consider hotfix with just that issue label Jul 11, 2017

DeepDiver1975 added 3 - To Review backport-request and removed 2 - Developing labels Jul 17, 2017

DeepDiver1975 approved these changes Jul 17, 2017

View reviewed changes

Philipp Schaffrath and others added 6 commits August 7, 2017 09:26

added migration from stable8.2 to stable9

bcfbe8e

addressbooks.description can be null

233e0aa

added missing changes from diff between migrated mysql table and nati…

e6982b0

…ve mysql table

added autoincrement, unsigned, notnull and collation explicitly

380893e

needed to set notnull to false explicitly and remove the collation de…

4164b17

…finition

order mounts by storage_id, because postgres returns it not in the or…

46c5a91

…der they where added which fails some expectations in tests

phisch force-pushed the stable10_upgrade_from_stable8_2 branch from d3006a3 to 46c5a91 Compare August 7, 2017 07:32

phisch merged commit 52a6f04 into master Aug 11, 2017

PVince81 deleted the stable10_upgrade_from_stable8_2 branch August 11, 2017 11:00

phisch mentioned this pull request Aug 11, 2017

[stable10] migration from stable8.2 to stable9 (#28256) #28655

Merged

PVince81 pushed a commit that referenced this pull request Aug 11, 2017

Merge pull request #28655 from owncloud/stable10-migrations-8-to-9

1f67bd6

[stable10] migration from stable8.2 to stable9 (#28256)

PVince81 removed the backport-request label Aug 15, 2017

lock bot locked as resolved and limited conversation to collaborators Aug 2, 2019

migration from stable8.2 to stable9 #28256

migration from stable8.2 to stable9 #28256

Uh oh!

Conversation

phisch commented Jun 29, 2017

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Types of changes

Checklist:

Uh oh!

phisch Jun 29, 2017

Choose a reason for hiding this comment

Uh oh!

DeepDiver1975 Jun 29, 2017

Choose a reason for hiding this comment

Uh oh!

PVince81 Jun 29, 2017

Choose a reason for hiding this comment

Uh oh!

phisch Jun 29, 2017

Choose a reason for hiding this comment

Uh oh!

PVince81 commented Jun 29, 2017 • edited by phisch Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

PVince81 commented Jun 29, 2017

Uh oh!

phisch commented Jul 12, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

PVince81 commented Jul 12, 2017

Uh oh!

CLAassistant commented Jul 13, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

PVince81 commented Jul 18, 2017

Uh oh!

phisch commented Jul 28, 2017

Uh oh!

PVince81 commented Aug 3, 2017

Uh oh!

PVince81 commented Aug 7, 2017

Uh oh!

PVince81 commented Aug 7, 2017

Uh oh!

phisch commented Aug 11, 2017

Uh oh!

PVince81 commented Aug 11, 2017

Uh oh!

PVince81 commented Aug 11, 2017

Uh oh!

phisch commented Aug 11, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lock bot commented Aug 2, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

PVince81 commented Jun 29, 2017 •

edited by phisch

Loading

phisch commented Jul 12, 2017 •

edited

Loading

CLAassistant commented Jul 13, 2017 •

edited

Loading

phisch commented Aug 11, 2017 •

edited

Loading