-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Update .htaccess #29344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update .htaccess #29344
Conversation
|
This is related to: owncloud-archive/documentation#2717 isn't it? Looks nextcloud/server#3370 did a different approach, not sure which one is "better". |
|
Yes, they are all related. But Windows need a 401 answer and not the 301 version as currently implemented. We made a lot of testing and our/this pull request version of .htaccess is the only really working with Win 7 to Win 10. On Nextcloud I made the same pull request as here on owncloud. Therefore same it will be the same approach on Nextcloud as for owncloud. The reply 301 only works, if the MS Webdav Service was already startet for some reasons. The initial startup of the MS Webdav Service needs the 401 reply to start the service on demand and this is the default behavior on a unchanged/unpatched Windows. |
|
See Screencast I made tonight: |
|
Does this need to be done in htaccess or can it be done in a Webdav plugin ? |
I'm having a hard time to judge on this .... |
|
@PVince81, I propose to merge this. Running nginx, the adequate ruleset solves the problem. |
ee256ac to
36b66fc
Compare
Codecov Report
@@ Coverage Diff @@
## master #29344 +/- ##
=========================================
Coverage 62.24% 62.24%
Complexity 18248 18248
=========================================
Files 1091 1091
Lines 61665 61665
=========================================
Hits 38386 38386
Misses 23279 23279Continue to review full report at Codecov.
|
|
There is an existing documentation for troubleshooting including this issue. |
|
@ownclouders rebase |
|
Hey! I'm GitMate.io! This pull request is being rebased automatically. Please DO NOT push while rebase is in progress or your changes would be lost permanently |
|
Automated rebase with GitMate.io was successful! 🎉 |
36b66fc to
b34b664
Compare
|
Info: The nginx part has been moved in the meanwhile to the new nginx config page. |
|
I wonder if it would be possible and better to implement this on application level, maybe in the Sabre plugins ? Mind explaining how the logic should work ? |
|
would rather have this in a SabreDAV plugin, to make Windows auto-login. this way we can also restrict the effect of the change to only this one client |
Send 401 on OPTIONS / HTTP/1.1 request coming from windows WebDAV service.
This way the WebClient Service on Windows starts automatically on request.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: