Skip to content

Conversation

@chriseqipe
Copy link
Contributor

Send 401 on OPTIONS / HTTP/1.1 request coming from windows WebDAV service.
This way the WebClient Service on Windows starts automatically on request.

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@ghost
Copy link

ghost commented Nov 11, 2017

This is related to:

owncloud-archive/documentation#2717
owncloud-archive/documentation#2668 (comment)
#26350

isn't it?

Looks nextcloud/server#3370 did a different approach, not sure which one is "better".

@chriseqipe
Copy link
Contributor Author

Yes, they are all related. But Windows need a 401 answer and not the 301 version as currently implemented. We made a lot of testing and our/this pull request version of .htaccess is the only really working with Win 7 to Win 10. On Nextcloud I made the same pull request as here on owncloud. Therefore same it will be the same approach on Nextcloud as for owncloud. The reply 301 only works, if the MS Webdav Service was already startet for some reasons. The initial startup of the MS Webdav Service needs the 401 reply to start the service on demand and this is the default behavior on a unchanged/unpatched Windows.

@chriseqipe
Copy link
Contributor Author

See Screencast I made tonight:
https://www.youtube.com/watch?v=T50ZYrNBaeo

@PVince81
Copy link
Contributor

Does this need to be done in htaccess or can it be done in a Webdav plugin ?

@DeepDiver1975

@DeepDiver1975
Copy link
Member

Does this need to be done in htaccess or can it be done in a Webdav plugin ?

I'm having a hard time to judge on this ....

@mmattel
Copy link
Contributor

mmattel commented Mar 7, 2018

@PVince81, I propose to merge this. Running nginx, the adequate ruleset solves the problem.

@codecov
Copy link

codecov bot commented Mar 9, 2018

Codecov Report

Merging #29344 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #29344   +/-   ##
=========================================
  Coverage     62.24%   62.24%           
  Complexity    18248    18248           
=========================================
  Files          1091     1091           
  Lines         61665    61665           
=========================================
  Hits          38386    38386           
  Misses        23279    23279

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5298f5e...b34b664. Read the comment docs.

@mmattel
Copy link
Contributor

mmattel commented Mar 9, 2018

There is an existing documentation for troubleshooting including this issue.
I have created a doc PR owncloud-archive/documentation#3891 to harmonize / fix the content and include a proper nginx ruleset. This is necessary to be on the safe side if this PR doesnt get merged!
In case of merging this core PR, I will post adapt the documentation.

@patrickjahns
Copy link
Contributor

@ownclouders rebase

@ownclouders
Copy link
Contributor

Hey! I'm GitMate.io! This pull request is being rebased automatically. Please DO NOT push while rebase is in progress or your changes would be lost permanently ⚠️

@ownclouders
Copy link
Contributor

Automated rebase with GitMate.io was successful! 🎉

@mmattel
Copy link
Contributor

mmattel commented Mar 19, 2018

Info: The nginx part has been moved in the meanwhile to the new nginx config page.

@PVince81
Copy link
Contributor

I wonder if it would be possible and better to implement this on application level, maybe in the Sabre plugins ?

Mind explaining how the logic should work ?

@PVince81
Copy link
Contributor

PVince81 commented Feb 8, 2019

would rather have this in a SabreDAV plugin, to make Windows auto-login.

this way we can also restrict the effect of the change to only this one client

cc @DeepDiver1975

@PVince81 PVince81 closed this Feb 8, 2019
@PVince81 PVince81 deleted the chriseqipe-patch-1 branch February 8, 2019 14:57
@lock lock bot locked as resolved and limited conversation to collaborators Feb 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants