Skip to content

Conversation

@DeepDiver1975
Copy link
Member

@DeepDiver1975 DeepDiver1975 commented Aug 3, 2021

Description

This allows storage implementations to specify the location for encryption keys
https://github.com/owncloud/files_spaces needs this because the space does not belong to a user.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@DeepDiver1975 DeepDiver1975 force-pushed the feat/storage-based-encryption-key-location branch from 96dfa14 to 7de9c82 Compare August 3, 2021 09:47
@DeepDiver1975 DeepDiver1975 changed the title Feat/storage based encryption key location feat: encryption keys location can be specified by the storage implementation Aug 3, 2021
@DeepDiver1975 DeepDiver1975 force-pushed the feat/storage-based-encryption-key-location branch from 7de9c82 to 07dc2f0 Compare August 3, 2021 10:27
@DeepDiver1975 DeepDiver1975 marked this pull request as ready for review August 4, 2021 08:59
@DeepDiver1975 DeepDiver1975 force-pushed the feat/storage-based-encryption-key-location branch from 07dc2f0 to 809fee8 Compare August 4, 2021 10:26
@cdamken
Copy link
Contributor

cdamken commented Aug 5, 2021

Is there a process to move the keys that are already on the users to be moved in the spaces?

@DeepDiver1975
Copy link
Member Author

Is there a process to move the keys that are already on the users to be moved in the spaces?

no - and I doubt that there is a general applicable solution.

keys are stored in the individual user's encryption key location.
I'd perform a manual analysis of the explicit system and move key files as needed ...

@DeepDiver1975 DeepDiver1975 force-pushed the feat/storage-based-encryption-key-location branch from 809fee8 to 235e9bd Compare August 5, 2021 13:35
@AlexAndBear AlexAndBear force-pushed the feat/storage-based-encryption-key-location branch from 46aef26 to c06a55b Compare August 10, 2021 09:20
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

80.0% 80.0% Coverage
0.0% 0.0% Duplication

$this->excludedPaths[] = 'avatar.png';
$this->excludedPaths[] = 'avatar.jpg';

// TODO: find a sophisticated solution
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah - that's fishy ....

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm afraid someone else has to come up with a more sophisticated solution, I don't see a general approach without mentioning the spaces app or providing a public interface to hook up to. This goes not only for this line here - we have multiple references to the spaces app, as you probably already have seen :(

@DeepDiver1975 DeepDiver1975 deleted the feat/storage-based-encryption-key-location branch December 1, 2021 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants