-
Notifications
You must be signed in to change notification settings - Fork 2.1k
feat: encryption keys location can be specified by the storage implementation #39091
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
96dfa14 to
7de9c82
Compare
7de9c82 to
07dc2f0
Compare
07dc2f0 to
809fee8
Compare
|
Is there a process to move the keys that are already on the users to be moved in the spaces? |
no - and I doubt that there is a general applicable solution. keys are stored in the individual user's encryption key location. |
809fee8 to
235e9bd
Compare
46aef26 to
c06a55b
Compare
|
Kudos, SonarCloud Quality Gate passed! |
| $this->excludedPaths[] = 'avatar.png'; | ||
| $this->excludedPaths[] = 'avatar.jpg'; | ||
|
|
||
| // TODO: find a sophisticated solution |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah - that's fishy ....
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm afraid someone else has to come up with a more sophisticated solution, I don't see a general approach without mentioning the spaces app or providing a public interface to hook up to. This goes not only for this line here - we have multiple references to the spaces app, as you probably already have seen :(








Description
This allows storage implementations to specify the location for encryption keys
https://github.com/owncloud/files_spaces needs this because the space does not belong to a user.
Related Issue
Types of changes
Checklist: