Skip to content

feat: encryption keys location can be specified by the storage implementation #40973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
phil-davis wants to merge 15 commits into from
Closed

feat: encryption keys location can be specified by the storage implementation #40973

phil-davis wants to merge 15 commits into from

Conversation

@phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Sep 5, 2023

Description

WIP - rebase of #39348 so that it can be used from apps and tested with current core master.

How Has This Been Tested?

WIP

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

DeepDiver1975 and others added 15 commits September 5, 2023 12:34
@DeepDiver1975 @phil-davis
feat: encryption keys location can be specified by the storage implem…
fa843cb 
…entation
@DeepDiver1975 @phil-davis
feat: decrypt the stream of a file version as returned by IVersionedS…
8801a9f 
…torage
@DeepDiver1975 @phil-davis
fix: encryption storage wrapper will only delete keys if the storage …
064591f 
…has no own key handling
@JammingBen @phil-davis
Add unit tests for versioned storage methods
4051662
@DeepDiver1975 @phil-davis
fix: handle encryption keys with trashbin
138a2bd
@DeepDiver1975 @phil-davis
feat: add before_moveToTrash hook + add fileId to delete hook
266af34
@DeepDiver1975 @phil-davis
feat: adding new storage method getFileKey
a268289
@DeepDiver1975 @phil-davis
feat: adding new storage method setFileKey
f2151cb
@DeepDiver1975 @phil-davis
fix: trashbin pre_restore hook and encryption version on move
56f677f
@DeepDiver1975 @phil-davis
feat: versioned storages are expected to handle retainVersions themse…
b2fbc88 
…lves
@DeepDiver1975 @phil-davis
fix: handle file rename properly
caaff4b
@DeepDiver1975 @phil-davis
feat: copy trashed items to all owner trash bins
1a61ff3
@DeepDiver1975 @phil-davis
feat: detect collisions of mounts wit local files
ef3a70b
@DeepDiver1975 @phil-davis
feat: add absolute paths to rename hook
56114d4
@phil-davis
Apply up-to-date PHP code style
3ed7a7a
@DeepDiver1975
Copy link
Member

DeepDiver1975 commented Sep 5, 2023

This is customer specific and has to stay on 10.9.x

@phil-davis phil-davis closed this Sep 14, 2023
@phil-davis phil-davis deleted the phil-storage-based-encryption-key-location-2 branch September 14, 2023 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@phil-davis @DeepDiver1975 @JammingBen