-
Notifications
You must be signed in to change notification settings - Fork 12
Run local server in its own folder #92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run local server in its own folder #92
Conversation
| pull: true | ||
| environment: | ||
| - COMPOSER_HOME=/var/www/owncloud/apps/password_policy/.cache/composer | ||
| - COMPOSER_HOME=/var/www/owncloud/server/apps/encryption/.cache/composer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also adjust some old cut-paste errors in phpstan and phan pipeline steps. These are steps that are for future use (the necessary commands are in ```Makefile`` but the code analysis fixes have not been made yet). They are not being actually run in CI yet. That is why these cut-paste errors were not causing any failure.
| - chown www-data /var/www/owncloud -R | ||
| - chmod 777 /var/www/owncloud/tests/acceptance/filesForUpload -R | ||
| - chmod +x /var/www/owncloud/tests/acceptance/run.sh | ||
| - chown www-data /var/www/owncloud/server -R |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could use:
| - chown www-data /var/www/owncloud/server -R | |
| - chown www-data /var/www/owncloud -R |
here and get rid of fix-permissions-federation-server:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, some day. CI takes >2 hours so I don't want to touch code unless I have to!
Codecov Report
@@ Coverage Diff @@
## master #92 +/- ##
=========================================
Coverage 62.75% 62.75%
Complexity 568 568
=========================================
Files 30 30
Lines 2081 2081
=========================================
Hits 1306 1306
Misses 775 775Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #92 +/- ##
=========================================
Coverage 62.75% 62.75%
Complexity 568 568
=========================================
Files 30 30
Lines 2081 2081
=========================================
Hits 1306 1306
Misses 775 775Continue to review full report at Codecov.
|
Currently the local server-under-test is being put into
/var/www/owncloudand then when a federated server is also required for a test suite, that is put in/var/www/owncloud/fed-serverThis is a recipe for confusion, and it did cause confusion last night due to changes in the way that the acceptance test
run.shfinds the location of the skeleton files. Under/var/www/owncloudthe skeleton files folder is found twice - in/var/www/owncloud/apps/testing/data...and in/var/www/owncloud/fed-server/apps/testing/dataIn core, the fed-server is installed into a completely separate folder tree. This is more realistic - in real life another server will usually even be on a completely separate machine.
This PR changes the location of the servers-under-test to:
local server in
/var/www/owncloud/serverfederated server in
/var/www/owncloud/fed-server(its current location)