-
Notifications
You must be signed in to change notification settings - Fork 5
Bump dependencies to support guzzle v6 #116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Note: CI does not run the unit tests. IMO that needs a test dropbox set up somehow/somewhere. If this goes ahead, then manual testing will be required. |
|
I did some testing. I was able to connect to Dropbox, list, rename & upload files. All other actions I tried (download, open) failed - but so they do with master. |
|
Also we should raise the minimum OC version to 10.9 with this PR. |
5fe7d7e to
567b22d
Compare
Done. We can leave this PR until we know all of the apps that need touching, and can make a decision about merging guzzle 7 in core... |
|
Note: update to Guzzle 7 in core is waiting until after 10.9.0 release. I converted this PR to Draft for now. |
567b22d to
7aedd8c
Compare
|
Rebased and got the dependencies up-to-date. Now composer.lock has guzzle Note: this app has no tests that run in automated CI, so it will need manual testing after core goes to guzzle 7.4.5 |
8619319 to
8b566fb
Compare
And bump owncloud min-version to 10.11
8b566fb to
2e110e3
Compare
|
I rebased just now. IMO we merge this, and put this app in the list of things to be released along with core 10.11 |
|
I made release issue #133 |
This gets
composer.lockhaving:https://github.com/kunalvarma05/dropbox-php-sdk/blob/master/composer.json only mentions guzzle v6 so far.
And https://github.com/Hemant-Mann/flysystem-dropbox/blob/master/composer.json requires:
So it looks like we can get to guzzle 6 easily, but guzzle 7 will need investigation.
Maybe guzzle v6 here will work OK with core guzzle 7 anyway? The separate
composer.lockof core and the app should find the right versions of dependencies as code is called.