Skip to content

Conversation

@phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Oct 21, 2021

This gets composer.lock having:

            "name": "guzzlehttp/guzzle",
            "version": "6.5.5",

https://github.com/kunalvarma05/dropbox-php-sdk/blob/master/composer.json only mentions guzzle v6 so far.

And https://github.com/Hemant-Mann/flysystem-dropbox/blob/master/composer.json requires:

"kunalvarma05/dropbox-php-sdk": "^0.2.0"

So it looks like we can get to guzzle 6 easily, but guzzle 7 will need investigation.

Maybe guzzle v6 here will work OK with core guzzle 7 anyway? The separate composer.lock of core and the app should find the right versions of dependencies as code is called.

@phil-davis phil-davis self-assigned this Oct 21, 2021
@phil-davis
Copy link
Contributor Author

Note: CI does not run the unit tests. IMO that needs a test dropbox set up somehow/somewhere. If this goes ahead, then manual testing will be required.

@phil-davis phil-davis marked this pull request as ready for review October 21, 2021 06:51
@JammingBen
Copy link
Contributor

I did some testing. I was able to connect to Dropbox, list, rename & upload files. All other actions I tried (download, open) failed - but so they do with master.

@JammingBen
Copy link
Contributor

Also we should raise the minimum OC version to 10.9 with this PR.

@phil-davis
Copy link
Contributor Author

Also we should raise the minimum OC version to 10.9 with this PR.

Done.

We can leave this PR until we know all of the apps that need touching, and can make a decision about merging guzzle 7 in core...

@phil-davis phil-davis marked this pull request as draft October 29, 2021 02:57
@phil-davis
Copy link
Contributor Author

Note: update to Guzzle 7 in core is waiting until after 10.9.0 release. I converted this PR to Draft for now.

@phil-davis
Copy link
Contributor Author

phil-davis commented Jun 15, 2022

Rebased and got the dependencies up-to-date. Now composer.lock has guzzle 7.4.4 7.4.5

Note: this app has no tests that run in automated CI, so it will need manual testing after core goes to guzzle 7.4.5

And bump owncloud min-version to 10.11
@phil-davis phil-davis marked this pull request as ready for review June 28, 2022 07:57
@phil-davis
Copy link
Contributor Author

I rebased just now. IMO we merge this, and put this app in the list of things to be released along with core 10.11

@JammingBen @janackermann

@phil-davis phil-davis merged commit 6a9036b into master Jun 28, 2022
@delete-merged-branch delete-merged-branch bot deleted the support-guzzle6 branch June 28, 2022 08:51
@phil-davis
Copy link
Contributor Author

I made release issue #133

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants