Skip to content

Conversation

@anon-pradip
Copy link
Contributor

@anon-pradip anon-pradip commented Jan 6, 2026

Description

  • Converts general.feature end-to-end test from Cucumber/Gherkin to Playwright
  • Removes the general.feature file as the test scenarios are now implemented in Playwright spec format
  • Removes legacy Cucumber step definitions (navigateToGeneralManagementPage, uploadLogoFromLocalPath, resetLogo)
  • Implements test scenarios using Playwright's native testing API with shared helper functions (general.spec.ts)
  • Updates test structure to use Playwright's modern testing patterns and beforeEach hooks
  • Maintains existing test coverage while improving test reliability and execution speed
  • Adds accessibility checks for logo management UI elements

Related Issue

Motivation and Context

How Has This Been Tested?

  • Locally
  • CI

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests
  • Documentation
  • Maintenance (e.g. dependency updates or tooling)

Open tasks:

  • ...

@anon-pradip anon-pradip self-assigned this Jan 6, 2026
@anon-pradip anon-pradip force-pushed the test/e2e-playwright-admin-settings-general.feature branch 3 times, most recently from 9503570 to d4eeef9 Compare January 7, 2026 07:17
@anon-pradip anon-pradip marked this pull request as ready for review January 7, 2026 07:18
@anon-pradip anon-pradip force-pushed the test/e2e-playwright-admin-settings-general.feature branch from d4eeef9 to 558f954 Compare January 7, 2026 07:44
@anon-pradip anon-pradip force-pushed the test/e2e-playwright-admin-settings-general.feature branch 2 times, most recently from 787d25a to 87d12f7 Compare January 7, 2026 10:55
@anon-pradip anon-pradip requested a review from saw-jan January 7, 2026 10:55
@anon-pradip anon-pradip force-pushed the test/e2e-playwright-admin-settings-general.feature branch from 87d12f7 to da8337c Compare January 8, 2026 04:12
@anon-pradip anon-pradip requested a review from saw-jan January 8, 2026 04:13
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@anon-pradip anon-pradip force-pushed the test/e2e-playwright-admin-settings-general.feature branch from da8337c to 840b0ce Compare January 9, 2026 07:34
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 9, 2026

@anon-pradip anon-pradip merged commit dc56349 into master Jan 9, 2026
4 checks passed
@anon-pradip anon-pradip deleted the test/e2e-playwright-admin-settings-general.feature branch January 9, 2026 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants