Skip to content

Conversation

@anon-pradip
Copy link
Contributor

@anon-pradip anon-pradip commented Jan 8, 2026

Description

This PR unifies accessibility violation assertions across e2e tests with centralized static method, eliminating code duplication and improving maintainability. Did not modify tests/e2e/cucumber/steps/ui/ because these cucumber related tests are eventually going to be cleaned up during the ongoing migrations to playwright.

Related Issue

  • Fixes <issue_link>

Motivation and Context

Cleaner test code

How Has This Been Tested?

  • test environment:
  • Local and CI

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests
  • Documentation
  • Maintenance (e.g. dependency updates or tooling)

Open tasks:

  • ...

@anon-pradip anon-pradip self-assigned this Jan 8, 2026
@anon-pradip anon-pradip force-pushed the test/unify-a11y-assertions branch from 88b4ad1 to 8ec53dc Compare January 8, 2026 11:19
@anon-pradip anon-pradip marked this pull request as ready for review January 8, 2026 11:19
@anon-pradip anon-pradip force-pushed the test/unify-a11y-assertions branch 2 times, most recently from 6e0354e to 3c51305 Compare January 8, 2026 11:31
@anon-pradip anon-pradip force-pushed the test/unify-a11y-assertions branch from 3c51305 to 44c6ddb Compare January 8, 2026 11:55
@anon-pradip anon-pradip requested a review from saw-jan January 8, 2026 11:55
@anon-pradip anon-pradip force-pushed the test/unify-a11y-assertions branch from 44c6ddb to fbd58d6 Compare January 9, 2026 04:23
@anon-pradip anon-pradip requested a review from saw-jan January 9, 2026 04:25
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 9, 2026

@anon-pradip anon-pradip merged commit 791ebd2 into master Jan 9, 2026
4 checks passed
@anon-pradip anon-pradip deleted the test/unify-a11y-assertions branch January 9, 2026 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants