Switching from @react-spring/web to framer-motion#2214
Closed
benjaminleonard wants to merge 9 commits intomainfrom
Closed
Switching from @react-spring/web to framer-motion#2214benjaminleonard wants to merge 9 commits intomainfrom
@react-spring/web to framer-motion#2214benjaminleonard wants to merge 9 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
benjaminleonard
commented
May 1, 2024
Collaborator
|
It's pretty out of date but I think this is a fine thing to do. I'm ok with a 6kb bundle bump if it lets us get nicer animations in the future. It looks like the bundle size reduction tips might have changed and and are now easier to follow. If you still want this @benjaminleonard, could you redo it on latest main? |
Contributor
Author
|
Closing and re-doing in #2646 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These libraries are very similar, but in places I prefer the
framer-motionAPI. One such case is that you can provide it an apple styledurationandbounceand still get a spring animation but without needing to contort your brain with friction, mass etc.framer-motiondoes have a much bigger bundle but you can keep it down by excluding the features we don't need. The layout features in particular are very powerful but we don't do any big native style transitions to make its inclusion justifiable.WIP as I might find a few other spots where we might include animation.