chore: Bump API to latest main, include autoRestartPolicy in instance update#2526
Merged
david-crespo merged 1 commit intomainfrom Oct 30, 2024
Merged
chore: Bump API to latest main, include autoRestartPolicy in instance update#2526david-crespo merged 1 commit intomainfrom
autoRestartPolicy in instance update#2526david-crespo merged 1 commit intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Oct 30, 2024
oxidecomputer/console@f7d6daf...6eeab20 * [6eeab203](oxidecomputer/console@6eeab203) oxidecomputer/console#2525 * [bdc1c87c](oxidecomputer/console@bdc1c87c) oxidecomputer/console#2526 * [23824251](oxidecomputer/console@23824251) oxidecomputer/console#2508 * [78e7e26b](oxidecomputer/console@78e7e26b) oxidecomputer/console#2524 * [eb7f8567](oxidecomputer/console@eb7f8567) oxidecomputer/console#2504 * [df0dea4a](oxidecomputer/console@df0dea4a) oxidecomputer/console#2514 * [3474c6ce](oxidecomputer/console@3474c6ce) oxidecomputer/console#2522 * [af6a89e7](oxidecomputer/console@af6a89e7) oxidecomputer/console#2520 * [4e967560](oxidecomputer/console@4e967560) oxidecomputer/console#2512
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Oct 30, 2024
oxidecomputer/console@f7d6daf...6eeab20 * [6eeab203](oxidecomputer/console@6eeab203) oxidecomputer/console#2525 * [bdc1c87c](oxidecomputer/console@bdc1c87c) oxidecomputer/console#2526 * [23824251](oxidecomputer/console@23824251) oxidecomputer/console#2508 * [78e7e26b](oxidecomputer/console@78e7e26b) oxidecomputer/console#2524 * [eb7f8567](oxidecomputer/console@eb7f8567) oxidecomputer/console#2504 * [df0dea4a](oxidecomputer/console@df0dea4a) oxidecomputer/console#2514 * [3474c6ce](oxidecomputer/console@3474c6ce) oxidecomputer/console#2522 * [af6a89e7](oxidecomputer/console@af6a89e7) oxidecomputer/console#2520 * [4e967560](oxidecomputer/console@4e967560) oxidecomputer/console#2512
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will conflict with #2488 because that also bumps the API, but it should be easy to resolve.
The
autoRestartPolicything is pretty important and also worrying because it's a bug that arises by you doing nothing, and you can't get a type error for it.autoRestartPolicyis optional on the instance update request body because you can leave it out (or pass in null or undefined) to unset the policy. But that means if you simply fail to include it, you are going to unset it on every update call. Here we fix that by always including the current value so it stays at whatever it is, but every client will have this problem.In practice this is probably not a huge deal, because
nullfalls back tobest-effort(omicron source).