Disallow firewall-rule subform submission when target / host filter value is missing#2550
Merged
david-crespo merged 1 commit intomainfrom Nov 13, 2024
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
charliepark
commented
Nov 13, 2024
| // addButton should be disabled again, as type has changed but no value has been entered | ||
| await expect(addButton).toBeDisabled() | ||
| await selectOption(page, subnetNameField, 'mock-subnet') | ||
| await expect(addButton).toBeEnabled() |
Contributor
Author
There was a problem hiding this comment.
This is technically covered by the click() and expectRowVisible on the next two lines, but I think having this line here (along with the expect…Disabled two lines up) makes it clear that the selectOption on the line in the middle of them is what enabled the button.
david-crespo
approved these changes
Nov 13, 2024
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Nov 14, 2024
oxidecomputer/console@9ef82ba...48fc079 * [48fc079a](oxidecomputer/console@48fc079a) oxidecomputer/console#2542 * [f3d38103](oxidecomputer/console@f3d38103) oxidecomputer/console#2545 * [eba6626d](oxidecomputer/console@eba6626d) bump API for moved system timeseries endpoints * [6052fdbf](oxidecomputer/console@6052fdbf) oxidecomputer/console#2549 * [b886e4b8](oxidecomputer/console@b886e4b8) oxidecomputer/console#2550 * [7303d9d7](oxidecomputer/console@7303d9d7) oxidecomputer/console#2551 * [e239a8e2](oxidecomputer/console@e239a8e2) oxidecomputer/console#2540 * [31520a2e](oxidecomputer/console@31520a2e) move Breadcrumbs component definition into TopBar.tsx * [ad02edec](oxidecomputer/console@ad02edec) minor: extract UserMenu component for readability
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Nov 14, 2024
oxidecomputer/console@9ef82ba...48fc079 * [48fc079a](oxidecomputer/console@48fc079a) oxidecomputer/console#2542 * [f3d38103](oxidecomputer/console@f3d38103) oxidecomputer/console#2545 * [eba6626d](oxidecomputer/console@eba6626d) bump API for moved system timeseries endpoints * [6052fdbf](oxidecomputer/console@6052fdbf) oxidecomputer/console#2549 * [b886e4b8](oxidecomputer/console@b886e4b8) oxidecomputer/console#2550 * [7303d9d7](oxidecomputer/console@7303d9d7) oxidecomputer/console#2551 * [e239a8e2](oxidecomputer/console@e239a8e2) oxidecomputer/console#2540 * [31520a2e](oxidecomputer/console@31520a2e) move Breadcrumbs component definition into TopBar.tsx * [ad02edec](oxidecomputer/console@ad02edec) minor: extract UserMenu component for readability Co-authored-by: iliana etaoin <iliana@oxide.computer>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We already had the logic in place to disable the
clearbutton in the subform, we just hadn't applied it to the submit button. This PR applies the same prop logic to both theclearand theaddbutton — you can't take either action if there's no value in the subform; if the value is there, you can take either action.Closes #2547