normalize combobox inputs; disallow spaces#2553
Merged
charliepark merged 5 commits intomainfrom Nov 14, 2024
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
david-crespo
approved these changes
Nov 14, 2024
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Nov 14, 2024
oxidecomputer/console@48fc079...0517a28 * [0517a281](oxidecomputer/console@0517a281) oxidecomputer/console#2541 * [510c6457](oxidecomputer/console@510c6457) oxidecomputer/console#2555 * [d7908192](oxidecomputer/console@d7908192) oxidecomputer/console#2553 * [16e86508](oxidecomputer/console@16e86508) oxidecomputer/console#2552
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Nov 14, 2024
oxidecomputer/console@48fc079...0517a28 * [0517a281](oxidecomputer/console@0517a281) oxidecomputer/console#2541 * [510c6457](oxidecomputer/console@510c6457) oxidecomputer/console#2555 * [d7908192](oxidecomputer/console@d7908192) oxidecomputer/console#2553 * [16e86508](oxidecomputer/console@16e86508) oxidecomputer/console#2552
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #2549, we set up a function (
normalizeName) that allows us to normalize inputs so they conform to the relevant string patterns for the Name field. This PR uses that same function and applies it to the values entered in to comboboxes. As a result of this, #2546 is fixed, as the function doesn't allow for whitespace characters.This is also the usecase where the
normalizeNamesecond parameter (allowNonLetterStart) comes in, as people might need to search for a number inside a combobox (e.g. "filter the combobox for all instance names that include22").Closes #2546