Set date pickers to match other input elements' heights#2561
Merged
charliepark merged 1 commit intomainfrom Nov 19, 2024
Merged
Set date pickers to match other input elements' heights#2561charliepark merged 1 commit intomainfrom
charliepark merged 1 commit intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
charliepark
changed the title
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Nov 19, 2024
oxidecomputer/console@0517a28...6fe6936 * [6fe6936d](oxidecomputer/console@6fe6936d) oxidecomputer/console#2328 * [fcd34418](oxidecomputer/console@fcd34418) oxidecomputer/console#2563 * [6e389ec6](oxidecomputer/console@6e389ec6) oxidecomputer/console#2561 * [41c4c5db](oxidecomputer/console@41c4c5db) oxidecomputer/console#2560 * [92472558](oxidecomputer/console@92472558) oxidecomputer/console#2562 * [9b60d5c9](oxidecomputer/console@9b60d5c9) oxidecomputer/console#2559 * [1e0486c2](oxidecomputer/console@1e0486c2) chore: npm audit fix * [7d35d268](oxidecomputer/console@7d35d268) oxidecomputer/console#2544
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Nov 19, 2024
oxidecomputer/console@0517a28...6fe6936 * [6fe6936d](oxidecomputer/console@6fe6936d) oxidecomputer/console#2328 * [fcd34418](oxidecomputer/console@fcd34418) oxidecomputer/console#2563 * [6e389ec6](oxidecomputer/console@6e389ec6) oxidecomputer/console#2561 * [41c4c5db](oxidecomputer/console@41c4c5db) oxidecomputer/console#2560 * [92472558](oxidecomputer/console@92472558) oxidecomputer/console#2562 * [9b60d5c9](oxidecomputer/console@9b60d5c9) oxidecomputer/console#2559 * [1e0486c2](oxidecomputer/console@1e0486c2) chore: npm audit fix * [7d35d268](oxidecomputer/console@7d35d268) oxidecomputer/console#2544
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Woof. We recently made comboboxes / listboxes larger, to match the height of input fields. The DatePicker component had an independent height, though, and so it wasn't matching the height of the listbox on the Metrics page. This fixes that, so DatePickers now match the other input components' heights.
Broken:
Fixed:
