Update silo creation form to require a TLS certificate

[charliepark]

This fixes a bug in the silo creation form, where a silo could be created without entering in TLS information.

The sub-form already had the TLS fields marked as required, but those requirements don't bubble up to the higher-order form. This adds a requirement to the body of the form, that the tls_certificates array be not-empty.

Augustus had an interesting idea about verifying Common Name and Subject Alternative Names in the cert fields, but this PR doesn't address that yet.

Closes #2578

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
console	✅ Ready (Inspect)	Visit Preview	Dec 3, 2024 9:56pm

[charliepark]

Chatting through this with Ben, and he's noting that it would be good for us to consider a minItems: 1 on the API for tls_certificates, so this is protected via CLI as well.

All of the current types in Nexus that have a minItems value also have an identical maxItems value, so are of a fixed length. So if approaching this in Rust, we might need to approach it differently than in other spots in the code.

[benjaminleonard]

Chatting through this with Ben, and he's noting that it would be good for us to consider a minItems: 1 on the API for tls_certificates, so this is protected via CLI as well.

Rather I meant that the minItems requirement is then documented in the API docs. Which we could probably also do with a comment.

[benjaminleonard]

This is a simple one, worth squeezing into R12? @david-crespo @charliepark

[david-crespo]

Yeah, probably.

[david-crespo]

This seems to work, but I was surprised about it since [] is truthy. Found this in the docs recommending validate over required for object and array values. I'll make that tweak now.

[david-crespo]

This all looks good to me. I'm still a little concerned about requiring a field in the UI that the API does not actually require, but the fix for that is almost certainly to have the API 400 if the list of certs has less than one element.

This looks a little tight, could use some space @benjaminleonard ?

[benjaminleonard]

Ship it, I feel like I want to rework that pattern where mini-table is hidden when there's no elements anyway, doesn't sit quite right.