minor: hook up Dialog.Title better in modal to fix Radix errors#2608
Merged
david-crespo merged 1 commit intomainfrom Dec 6, 2024
Merged
minor: hook up Dialog.Title better in modal to fix Radix errors#2608david-crespo merged 1 commit intomainfrom
Dialog.Title better in modal to fix Radix errors#2608david-crespo merged 1 commit intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
david-crespo
commented
Dec 6, 2024
| {children} | ||
| <Dialog.Close | ||
| className="absolute right-2 top-4 flex items-center justify-center rounded p-2 hover:bg-hover" | ||
| className="absolute right-2 top-3.5 flex items-center justify-center rounded p-2 hover:bg-hover" |
Collaborator
Author
There was a problem hiding this comment.
It was very slightly too low.
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Dec 6, 2024
oxidecomputer/console@fd47bee...927c8b6 * [927c8b63](oxidecomputer/console@927c8b63) oxidecomputer/console#2608 * [01a0ac99](oxidecomputer/console@01a0ac99) oxidecomputer/console#2597 * [243c55d7](oxidecomputer/console@243c55d7) oxidecomputer/console#2606 * [deb5e187](oxidecomputer/console@deb5e187) oxidecomputer/console#2603 * [67633aac](oxidecomputer/console@67633aac) oxidecomputer/console#2601 * [6405e0cb](oxidecomputer/console@6405e0cb) oxidecomputer/console#2605 * [8c37bad2](oxidecomputer/console@8c37bad2) oxidecomputer/console#2602 * [081599c3](oxidecomputer/console@081599c3) oxidecomputer/console#2599
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Dec 6, 2024
oxidecomputer/console@fd47bee...927c8b6 * [927c8b63](oxidecomputer/console@927c8b63) oxidecomputer/console#2608 * [01a0ac99](oxidecomputer/console@01a0ac99) oxidecomputer/console#2597 * [243c55d7](oxidecomputer/console@243c55d7) oxidecomputer/console#2606 * [deb5e187](oxidecomputer/console@deb5e187) oxidecomputer/console#2603 * [67633aac](oxidecomputer/console@67633aac) oxidecomputer/console#2601 * [6405e0cb](oxidecomputer/console@6405e0cb) oxidecomputer/console#2605 * [8c37bad2](oxidecomputer/console@8c37bad2) oxidecomputer/console#2602 * [081599c3](oxidecomputer/console@081599c3) oxidecomputer/console#2599
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed the
DialogTitleerror, which, I was dismayed to see, is not suppressed in production. Maybe for good reason, because it got me to fix it.Note that the accessible title was actually not broken in production — the problem here is that we were hooking up the title ID to the dialog ourselves rather than letting Radix dialog handle it, so it thought we weren't doing it.