Move error into picker

[benjaminleonard]

Fixes #2778

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
console	✅ Ready (Inspect)	Visit Preview	Apr 4, 2025 5:11pm

[david-crespo]

Nice! Non-focused border doesn't go all the way around:

[david-crespo]

Green dot in red day.

[benjaminleonard]

Nice! Non-focused border doesn't go all the way around:

It actually doesnt go round in either, the ring is tricking you. Will take a look at both.

[david-crespo]

Out of scope for this PR because it's about the picker state logic, but I find this interaction weird. I make the range invalid by setting end time before start time, which makes sense, but then the way we keep the invalid range around is kind of odd: if I click two different days, then we get a valid range because of course 4/3 10pm - 4/4 9pm is a valid range. But then I click the same day twice and it becomes invalid again because 4/3 10pm - 4/3 9pm is invalid. I understand the logic, and maybe it's just consistent and there isn't a better way, but I feel like maybe we could be more aggressive in resetting the times, or we could make clearer visually that the start time is associated with the start date, maybe by displaying the date above the times. Right now it feels a little disjointed because you have to look at both the input at the bottom of the popover and the thing at the top to really understand what you've chosen. The times at the bottom look like a time range within a single day, which is only true when the start and end days are the same.

2025-04-04-date-picker-error-states.mp4

[benjaminleonard]

Out of scope for this PR because it's about the picker state logic, but I find this interaction weird.

I think we could make a general issue for datepicker nits now we've sat with the current implementation for a while.

[benjaminleonard]

Today dot and focused border should be fixed now

[david-crespo]

fantastic, huge improvement