Bump Omicron version and add IP Pool type field to IP Pool create form #2951
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Collaborator
|
Looks fine to me vertical. Maybe add an e2e test creating a multicast one and seeing that it shows up in the table as multicast? |
david-crespo
approved these changes
Oct 28, 2025
Collaborator
david-crespo
left a comment
david-crespo
left a comment
There was a problem hiding this comment.
Looks good. Something I am wondering about for the future is whether we should be linking to the docs on more forms. We have it on the list page, but if you're in the form and you want to know what unicast/multicast is, you want the docs, and it would be great to just have a link right there.
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Oct 28, 2025
oxidecomputer/console@f9854c6...3947c8c * [3947c8c8](oxidecomputer/console@3947c8c8) oxidecomputer/console#2951 * [092937a7](oxidecomputer/console@092937a7) oxidecomputer/console#2950 * [bc543f80](oxidecomputer/console@bc543f80) oxidecomputer/console#2948 * [d9d35da1](oxidecomputer/console@d9d35da1) oxidecomputer/console#2945 * [8df79f45](oxidecomputer/console@8df79f45) oxidecomputer/console#2946 * [68973414](oxidecomputer/console@68973414) oxidecomputer/console#2941 * [3f5e7e60](oxidecomputer/console@3f5e7e60) oxidecomputer/console#2947
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Oct 29, 2025
oxidecomputer/console@f9854c6...3947c8c * [3947c8c8](oxidecomputer/console@3947c8c8) oxidecomputer/console#2951 * [092937a7](oxidecomputer/console@092937a7) oxidecomputer/console#2950 * [bc543f80](oxidecomputer/console@bc543f80) oxidecomputer/console#2948 * [d9d35da1](oxidecomputer/console@d9d35da1) oxidecomputer/console#2945 * [8df79f45](oxidecomputer/console@8df79f45) oxidecomputer/console#2946 * [68973414](oxidecomputer/console@68973414) oxidecomputer/console#2941 * [3f5e7e60](oxidecomputer/console@3f5e7e60) oxidecomputer/console#2947
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR bumps Omicron to the latest version. To do this, we need to add a
unicast/multicastfield to the IP Pools' create form, and also a column to the table showing IP Pools.