minor: try to fix firewall rule test flake again #2993
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Collaborator
Author
|
Three runs, one flake, no failures. |
david-crespo
force-pushed
the
ff-flake
branch
from
21108c8 to
3bf5665
Compare
david-crespo
force-pushed
the
ff-flake
branch
from
3bf5665 to
2286516
Compare
david-crespo
commented
Dec 18, 2025
| e.preventDefault() // prevent full form submission | ||
| submitProtocol(e) | ||
| } | ||
| }} |
Collaborator
Author
There was a problem hiding this comment.
This wasn't causing the flake because we weren't pressing enter in this field in the test, but it was wrong. You could submit the whole form by pressing enter in this field.
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Dec 30, 2025
oxidecomputer/console@e8b79c3...a5fc417 * [a5fc417d](oxidecomputer/console@a5fc417d) oxidecomputer/console#2984 * [8009ce4d](oxidecomputer/console@8009ce4d) oxidecomputer/console#2998 * [c7c2278e](oxidecomputer/console@c7c2278e) oxidecomputer/console#2997 * [be1cfc63](oxidecomputer/console@be1cfc63) oxidecomputer/console#2989 * [b1fba783](oxidecomputer/console@b1fba783) oxidecomputer/console#2992 * [08d801f0](oxidecomputer/console@08d801f0) oxidecomputer/console#2995 * [46a6b5ef](oxidecomputer/console@46a6b5ef) oxidecomputer/console#2996 * [43df666b](oxidecomputer/console@43df666b) oxidecomputer/console#2994 * [4b1a7569](oxidecomputer/console@4b1a7569) oxidecomputer/console#2993 * [867e4dae](oxidecomputer/console@867e4dae) oxidecomputer/console#2991 * [ff400c34](oxidecomputer/console@ff400c34) oxidecomputer/console#2988
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Dec 31, 2025
oxidecomputer/console@e8b79c3...a5fc417 * [a5fc417d](oxidecomputer/console@a5fc417d) oxidecomputer/console#2984 * [8009ce4d](oxidecomputer/console@8009ce4d) oxidecomputer/console#2998 * [c7c2278e](oxidecomputer/console@c7c2278e) oxidecomputer/console#2997 * [be1cfc63](oxidecomputer/console@be1cfc63) oxidecomputer/console#2989 * [b1fba783](oxidecomputer/console@b1fba783) oxidecomputer/console#2992 * [08d801f0](oxidecomputer/console@08d801f0) oxidecomputer/console#2995 * [46a6b5ef](oxidecomputer/console@46a6b5ef) oxidecomputer/console#2996 * [43df666b](oxidecomputer/console@43df666b) oxidecomputer/console#2994 * [4b1a7569](oxidecomputer/console@4b1a7569) oxidecomputer/console#2993 * [867e4dae](oxidecomputer/console@867e4dae) oxidecomputer/console#2991 * [ff400c34](oxidecomputer/console@ff400c34) oxidecomputer/console#2988
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.