Skip to content

Conversation

@yxtay
Copy link
Contributor

@yxtay yxtay commented Feb 14, 2025

Fixes #

Proposed Changes

  1. Documentation changes to use GitHub private email address for megalinter-bot.
    Not sure if it is intentional to expose @nvuillam email address in the docs, using a private email is good alternative.

  2. I have done a search and replace in the whole repo. The only one left unchanged is the changelog from 2023-04-01.

GitHub private email documentation

Readiness Checklist

Author/Contributor

  • Add entry to the CHANGELOG listing the change and linking to the corresponding issue (if appropriate)
  • If documentation is needed for this change, has that been included in this pull request

Reviewing Maintainer

  • Label as breaking if this is a large fundamental change
  • Label as either automation, bug, documentation, enhancement, infrastructure, or performance

@yxtay yxtay changed the title docs: use github private email docs: use github private email for megalinter-bot Feb 14, 2025
Copy link
Member

@nvuillam nvuillam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good PR, thanks :) plz handle comments :)

@yxtay
Copy link
Contributor Author

yxtay commented Feb 14, 2025

Oops, I did not realise my formatter changed so many things in the README. Have reverted most of the change.

@yxtay yxtay requested a review from nvuillam February 14, 2025 13:17
Copy link
Member

@nvuillam nvuillam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a lot :)

@nvuillam nvuillam merged commit a2ff398 into oxsecurity:main Feb 14, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants