feat: support compatibility with nanosecond MID precision (phase 1) #248
Merged
Conversation
microseconds compatibility (cast to milliseconds)
# Conflicts: # frac/meta_data_collector.go
…will always store milliseconds)
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #248 +/- ##
==========================================
- Coverage 71.22% 71.13% -0.09%
==========================================
Files 200 201 +1
Lines 14586 14707 +121
==========================================
+ Hits 10389 10462 +73
- Misses 3466 3506 +40
- Partials 731 739 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…232-nanos-support-phase-1
forshev
reviewed
Nov 18, 2025
eguguchkin
approved these changes
Nov 21, 2025
eguguchkin
reviewed
Nov 21, 2025
forshev
approved these changes
Nov 21, 2025
…232-nanos-support-phase-1 # Conflicts: # network/grpcutil/interceptors.go
b675288 to
48e447c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The is the intermediate version for supporting nanosecond MID. This version still operates in millisecond MIDs, but is compatible with the current (main) version as well as with future (phase 2) version where
seq.MIDcontains nanoseconds. This allows us to rollback in case of problem with the future version.seq.MIDare still in milliseconds.seq.MIDare in nanoseconds. This version silently converts them to millisecondsseq.MIDin nanoseconds. This version converts them to milliseconds as well.seq.MIDinside stored JSON. If we see a different version (naonseconds), we convert them to millis and change version.seq.MIDand we can not change versions.seq.IDstring representation is added. If MID is in nanoseconds, then delimiter is_instead of-. In this version, if we see_delimiter, then we convert to milliseconds.Relates to #232
If you have used LLM/AI assistance please provide model name and full prompt: