Skip to content

Conversation

@markborkum
Copy link
Contributor

Description

Use the most recent minor version of ANTLR4 prior to the release of version 4.8.

See https://pypi.org/project/antlr4-python3-runtime/#history for details.

Issues Resolved

Fixes #42

Check List

  • All tests pass.
  • New functionality includes testing.
  • New functionality has been documented in the README if applicable

@markborkum markborkum requested a review from dmlb2000 January 16, 2020 23:01
@dmlb2000
Copy link
Member

@markborkum I think you could do something like <4.8 and that might be better

@markborkum
Copy link
Contributor Author

@dmlb2000 ~=4.7 would be safer (since the underlying issue is breaking changes introduced by minor versions, this would also guard against out-of-date package managers that serve 4.6 or lower). Regardless, there are not going to be any new releases below 4.8, so let's stick with the explicit version, please.

@dmlb2000 dmlb2000 merged commit a616d9c into master Jan 23, 2020
@dmlb2000 dmlb2000 deleted the bugfix/pin-version-of-antlr4-python3-runtime branch January 23, 2020 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ANTLR runtime and generated code versions disagree: 4.8!=4.7.1

3 participants