Make PackageURLBuilder::getQualifiers return Map#157
Merged
jeremylong merged 1 commit intopackage-url:masterfrom Mar 11, 2025
Merged
Make PackageURLBuilder::getQualifiers return Map#157jeremylong merged 1 commit intopackage-url:masterfrom
PackageURLBuilder::getQualifiers return Map#157jeremylong merged 1 commit intopackage-url:masterfrom
Conversation
The return type of the method `PackageURLBuilder::getQualifiers` should be an interface, such as `Map`, rather than the implementation `TreeMap`. This aligns with the return type of the method `PackageURL::getQualifiers`. Also, make the return types of this method match the return types of `PackageURL::getQualifiers`. Note that this a potentially breaking API change.
dwalluck
force-pushed
the
package-url-builder-get-qualifiers
branch
from
d72ecba to
cba13d5
Compare
Contributor
Author
|
Note that it is considered better practice to have |
jeremylong
approved these changes
Mar 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The return type of the method
PackageURLBuilder::getQualifiersshould be an interface, such asMap, rather than the implementationTreeMap. This aligns with the return type of the methodPackageURL::getQualifiers.Also, make the return types of this method match the return types of
PackageURL::getQualifiers.Note that this a potentially breaking API change.