[WIP] Refactor actions project as NodeJS#10
Draft
LecrisUT wants to merge 1 commit intopackit:mainfrom
Draft
Conversation
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have been considering whether to use composite or TS/JS based action. I am not sure which one would be better, but maybe it can be mixed-and-matched
Comparison
Composite:
Pro
Con
Proposal
NodeJS:
Pro
Con
actions/toolkitProposal
Basically I believe we can achieve the same functionality with either framework, but this one provides better testing capabilities. One major con for JS framework is the complexity for calling other actions. Maybe we could call other JS actions, but I need to experiment more on how to do that.