Add another validate-config hook #38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpopelka
force-pushed
the
validate-config-no-container
branch
from
067ac4d to
28ddf20
Compare
lachmanfrantisek
approved these changes
May 9, 2023
Comment on lines
16
to
23
| ### Using check-rebase with pre-commit | ||
|
|
||
| Add this to your `.pre-commit-config.yaml` | ||
|
|
||
| - repo: https://github.com/packit/pre-commit-hooks | ||
| rev: the revision or tag to clone at | ||
| rev: v1.2.0 | ||
| hooks: | ||
| - id: check-rebase | ||
| - id: validate-config | ||
| - id: check-rebase |
Member
There was a problem hiding this comment.
Can you please update the title to match the example?
Member
Author
There was a problem hiding this comment.
I've split it and added separate examples for the new hooks.
mfocko
approved these changes
May 9, 2023
to run 'packit validate-config' directly. The previously added validate-config hook has been renamed to validate-config-in-container. Fixes packit#36
jpopelka
force-pushed
the
validate-config-no-container
branch
from
28ddf20 to
b77c319
Compare
softwarefactory-project-zuul bot
added a commit
to packit/packit
that referenced
this pull request
May 9, 2023
Dogfood our validate-config pre-commit hook Related packit/pre-commit-hooks#37, packit/pre-commit-hooks#38 Reviewed-by: František Lachman Reviewed-by: Laura Barcziová Reviewed-by: Matej Focko
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to run
packit validate-configdirectly.The previously added
validate-confighook has been renamed tovalidate-config-in-container.Fixes #36