Release version 2.3.0 #57
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ISSUE: PLCR25-4
…mation ISSUE: PLCR25-5
ISSUE: PLCR25-6
ISSUE: PLCR25-4
ISSUE: PLCR25-13
mpramon
approved these changes
Jan 11, 2021
Moratojkd
reviewed
Jan 11, 2021
| $locationService = TestServiceRegister::getService(LocationService::CLASS_NAME); | ||
| $locations = $locationService->getLocations(1, 'NL', '1011AS'); | ||
|
|
||
| $this->assertEmpty($locations); |
Contributor
There was a problem hiding this comment.
why empty? should be it formatted to 1011-AS and obtain location?
Contributor
There was a problem hiding this comment.
Because there are no drop-off locations for the selected country and postal code selection. The postal code does get transformed to the appropriate format, but the Packlink API returns an empty response for that request.
Moratojkd
reviewed
Jan 12, 2021
| * @var array | ||
| */ | ||
| protected static $map = array( | ||
| 'GB' => array( |
Contributor
There was a problem hiding this comment.
Great bretain has another countries iso codes where this transformation should be applied:
ISLE_MAN = "IM"
JERSEY = "JE"
GUERNSEY = "GG"
(array would be the same that GB)
Contributor
There was a problem hiding this comment.
These ISO codes will be added to the postal code transformer.
ISSUE: CS-1645
Moratojkd
approved these changes
Jan 18, 2021
kamikaziii
added a commit
to kamikaziii/ecommerce_module_core
that referenced
this pull request
Dec 23, 2025
Adds killswitch pattern to prevent infinite wakeup loops when no tasks are pending, reducing CPU usage by 90-97% on idle systems. Changes: - Add hasPendingTasks() method with LIMIT 1 optimization - Modify wakeup() to check queue before scheduling next run - Implement narrow fail-safe for query-specific exceptions - Add comprehensive test coverage (5 unit tests) Production validation: - Before: 37,000 CPU seconds/day (17,280 wakeups) - After: ~1,000 CPU seconds/day (~50 wakeups) - Reduction: 97% 100% backward compatible - no breaking changes. Fixes packlink-dev#57
9 tasks
kamikaziii
added a commit
to kodekrakan-commerce/packlink-integration-core
that referenced
this pull request
Dec 24, 2025
Adds killswitch pattern to prevent infinite wakeup loops when no tasks are pending, reducing CPU usage by 90-97% on idle systems. Changes: - Add hasPendingTasks() method with LIMIT 1 optimization - Modify wakeup() to check queue before scheduling next run - Implement narrow fail-safe for query-specific exceptions - Add comprehensive test coverage (5 unit tests) Production validation: - Before: 37,000 CPU seconds/day (17,280 wakeups) - After: ~1,000 CPU seconds/day (~50 wakeups) - Reduction: 97% 100% backward compatible - no breaking changes. Fixes packlink-dev#57
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed