Fix changed_lines number calculation#336
Merged
Merged
Conversation
`\ No newline at end of file` is inserted when the file does not contain LF at EOF. Ignore the message to count line numbers correctly.
Member
|
@radomirbosak @soutaro shipped it! https://rubygems.org/gems/git_diff_parser/versions/4.0.0 |
Author
|
Thank you for the quick reply and release @sanemat 😄 You are the best! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
\ No newline at end of fileis inserted when the file does not contain LF at EOF. Ignore the message to count line numbers correctly.This is a commit I found in @soutaro's branch fix-no-newline-at-eof, but I think it would be useful to have this patch merged in upstream too.
Tested with
bin/consoleon a small sample diff file.Fixes #335