This repository was archived by the owner on Jan 18, 2021. It is now read-only.
Open
Conversation
added 3 commits
April 9, 2016 16:12
…ve busy waiting in query_results
Contributor
|
Hey. Thanks for the fix. This is a great fix to my double back timer. I was the original author to this library and no longer am with the organization. I believe the branch owner no longer is maintaining this code. I am maintaining this library as a fork here. https://github.com/dashawn888/sqlite3worker If you would like to put a merge request on the above I will merge it. If not I will add this myself and comment in the code that this is your fix. |
Author
|
Hi,
Thanks for getting back to me. I would create a merge request in next
couple of days for you to review.
Thanks,
Aman
…On Fri, Feb 24, 2017 at 6:57 AM, Shawn Lee ***@***.***> wrote:
Hey. Thanks for the fix. This is a great fix to my double back timer. I
was the original author to this library and no longer am with the
organization. I believe the branch owner no longer is maintaining this
code. I am maintaining this library as a fork here.
https://github.com/dashawn888/sqlite3worker
If you would like to put a merge request on the above I will merge it. If
not I will add this myself and comment in the code that this is your fix.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#8 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACkWWlfn2ZHdiZIBAFlvSVgvIRiHNNuVks5rfjHxgaJpZM4IDlsu>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unnecessary CPU cycles were being wasted in busy waiting happening inside query_results method. Added synchronisation using threading.Event for select queries to improve the performance overall.