Flag_value not working in 8.3.1

[wabiloo]

Sorry for opening a new bug.
I understood (maybe wrongly) that #3130 had been completed.

Yet, when I moved to 8.3.1, I still have the same issue.
Is this meant for an 8.3.2 or do we have to wait for 9.0.0 for that to be fixed?

[ThiefMaster]

Please provide a minimal example of how exactly it is "not working".

[hilderic]

Use the example shown in #3130. Sample output:

$ python num.py --number 77
Hello, number is: 77!
$ python num.py
Hello, number is: 0!
$ python num.py --number
Error: Option '--number' requires an argument.

The third invocation should have reported Hello, number is: 1!.
This does work correctly under 8.2.1.

[codingjoe]

This issue was also raised here: mkdocs/mkdocs#4032 (comment)

[worksbyfriday]

This is the same root cause as #3130. I have an open PR fixing it: #3213.

The issue is that when flag_value is set to a callable class (like int), click stores it as the default via self.default = self.flag_value. Later, get_default() calls self.default() because it detects default is callable — but the user intended int to be the value, not a factory. The fix tracks whether the default was set from flag_value and skips the callable check in that case.

[kdeldycke]

This looks like the same issue as #3084, which as been fixed by #3152 .

It's going to be part of the upcoming 8.3.2 release. In the mean time, can you test the development version of Click and check that it fix your issue?