Wrapped public messages with gettext for i18n support#1829
Merged
Conversation
Saif807380
force-pushed
the
add-i18n
branch
2 times, most recently
from
29f9064 to
a9d2c12
Compare
davidism
reviewed
Apr 3, 2021
davidism
reviewed
Apr 3, 2021
davidism
force-pushed
the
add-i18n
branch
2 times, most recently
from
42e1b6d to
6371b89
Compare
ThiefMaster
reviewed
Apr 3, 2021
Member
ThiefMaster
left a comment
ThiefMaster
left a comment
There was a problem hiding this comment.
There may be more cases where we have surrounding whitespace in a translatable string.
Comment on lines
-137
to
+147
| msg += f". {msg_extra}" | ||
| msg += f". {msg_extra}" |
Member
There was a problem hiding this comment.
I don't think this should be changed. It's common for commandline tools (and other plaintext-based systems) to have two spaces after a colon.
Member
There was a problem hiding this comment.
It's been inconsistent across all the projects, I've been standardizing on single space after period for years now. This is the only remaining case of two spaces after a period in Click (excluding old docs and comments).
Member
|
Doesn't look like there's surrounding space in any of the messages now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes made -
I'm not sure if
__repr__need to be wrapped.Checklist:
CHANGES.rstsummarizing the change and linking to the issue... versionchanged::entries in any relevant code docs.pre-commithooks and fix any issues.pytestandtox, no tests failed.