quote BASH_VERSION to avoid special characters on Windows

[liooil]

#2461
wrap BASH_VERSION with "" to avoid "(" ")" in BASH_VERSION

• fixes #

Checklist:

• Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
• Add or update relevant docs, in the docs folder and in code.
• Add an entry in CHANGES.rst summarizing the change and linking to the issue.
• Add .. versionchanged:: entries in any relevant code docs.
• Run pre-commit hooks and fix any issues.
• Run pytest and tox, no tests failed.

[saroad2]

Hery @liooil , thanks for your contribution!

I was asking myself: why not simply use os.environ here if we are just looking for environment variable? Is there a specific reason we are not using it?

@davidism , it might be a question you could help us answer.

[davidism]

why not simply use os.environ here

It's only available directly in a bash shell process, not in launched processes. It's also only available from bash, but you may want to generate the file from another shell.

done